Restore file modification times - Githubissues

meltwater / drone-cache

A Drone plugin for caching current workspace files between builds to reduce your build times

https://underthehood.meltwater.com/blog/2019/04/10/making-drone-builds-10-times-faster/

Apache License 2.0

338 stars 81 forks source link

Restore file modification times #212

Closed CthulhuDen closed 1 year ago

CthulhuDen commented 2 years ago

Fixes #210

Proposed Changes

First, archive/tar now uses PAX tar format which allows for sub-second resolutions (https://pkg.go.dev/archive/tar#Format). This only affects rebuild's, so previosly built archive will not be broken.
And then extracting files, it sets times if file header container modification time.
Please not that only files' timestamps are currently restored, not directories'.

Description

In line with the liked issue, currently restored files (when using filesystem backend) do not preserve original timestamps, which leads to some build systems to rebuild. This PR fixes that.

Checklist

[x] Read the CONTRIBUTING document.
[x] Read the CODE OF CONDUCT document.
[x] Ensure your code follows the code style of this project.
[X] Ensure CI and all other PR checks are green
[x] Add your changes to Unreleased section of CHANGELOG.
[x] Ensure documentation is up-to-date.

bdebyl commented 1 year ago

@CthulhuDen could you pull from master and ensure your additions in the CHANGELOG are under the v1.4.0 release we're planning to get out?

After that's done I can merge it.