meltwater / drone-cache

A Drone plugin for caching current workspace files between builds to reduce your build times
https://underthehood.meltwater.com/blog/2019/04/10/making-drone-builds-10-times-faster/
Apache License 2.0
338 stars 81 forks source link

Remove liche and embedmd (generate) steps from CI #220

Closed bdebyl closed 1 year ago

bdebyl commented 1 year ago

Describe the bug The generate step dependencies are causing build errors on new PRs with silent errors. Reproducing locally shows error messages that can essentially be attributed to both liche and embedmd being old and unmaintained. It's suggested to remove these steps and simply omit their usage as they are not vital to the applications ability to be used.

To Reproduce Steps to reproduce the behavior:

Expected behavior Passing generate step.

Additional context The embedmd functionality isn't referenced any more and isn't required.

The liche URL checking is broken. Personally, I'd just remove this link checking as it's not vital or migrate to another link checker to ensure we do not have broken links in the documentation. Ultimately this shouldn't really be part of build steps for new PRs, as links in new PRs should be caught during review.

bdebyl commented 1 year ago

https://github.com/meltwater/drone-cache/pull/221