search

meltwater / drone-convert-pathschanged

Drone conversion extension to include/exclude pipelines and pipeline steps based on paths changed
https://docs.drone.io/extensions/conversion/
Apache License 2.0
134 stars 38 forks source link

Plans to support Jsonnet #65

Open mhemken-nyt opened 3 years ago

mhemken-nyt commented 3 years ago

Hello, Jsonnet is a much more flexible configuration language than yaml. My use case is one where a .drone.yml file would repeat code dozens of times. Jsonnet allows me to stay DRY. But this plugin doesn't work if I use a .drone.jsonnet file directly.

Are there plans to support Jsonnet with this plugin?

jimsheldon commented 2 years ago

Just to make sure I understand, you have set DRONE_JSONNET_ENABLED=true for your drone server, which allows drone to read .drone.jsonnet files in your repo rather than .drone.yml?

This doesn't directly solve your problem, but I believe it should be possible to convert your .drone.jsonnet file to a .drone.yml with the drone jsonnet command, which would be compatible with this plugin.

Our team will discuss potentially adding this feature and reply back.

jimsheldon commented 2 years ago

I have discussed this with my team. We don't have any immediate plans to support this feature, but we would welcome a pull request to add it.

For anyone else who would like to see this, please add a thumbs up to the initial post so we can measure interest.

raphendyr commented 2 years ago

See https://github.com/drone/drone/pull/2994

hikerspath commented 2 years ago

As @raphendyr mentions above, this is a long-running issue and waiting on the support of multiple convert plugins.

hikerspath commented 2 years ago

FWIW, should be no changes needed to existing footprint drone is able to execute multiple convert plugins.

wez commented 1 year ago

FWIW, setting DRONE_CONVERT_MULTI=true and DRONE_STARLARK_ENABLED=true on the drone server allows mixing both starlark and this conversion plugin.