search

meltwater / puppet-marathon

Puppet Module for Mesos Marathon
Apache License 2.0
6 stars 19 forks source link

Redhat systems need to use 'redhat', not 'init' #18

Closed ghost closed 8 years ago

ghost commented 8 years ago

I believe that Redhat-derived systems are the only ones still using sysv style inits, so they should use the 'redhat' provider.

A reference: https://docs.puppet.com/puppet/latest/reference/type.html#service-provider-redhat

salimane commented 8 years ago

@ryankrabath-ws thanks for the PR.

Please update the patch to check for redhat system specifically and set them.

Add also a test case for this.

Thanks

ghost commented 8 years ago

@salimane Thanks for your consideration.

I believe I've covered your requests. Please let me know if you see anything else missing.

ghost commented 8 years ago

Hi @salimane

Is it possible to get this merged, or does it need further work?

Happy to look into any further issues that you see.

salimane commented 8 years ago

@ryankrabath-ws sorry for the delay, I wanted to test this in a centos 6 vm before merging this.

salimane commented 8 years ago

@ryankrabath-ws instead of redhat, could you use init ?

ghost commented 8 years ago

@salimane During my testing, I found that when using init as the provider the service does not get set to start at boot. It appears as though we need the enableable feature, which init doesn't support:

https://docs.puppet.com/puppet/latest/reference/type.html#service-provider-init https://docs.puppet.com/puppet/latest/reference/type.html#service-provider-redhat

salimane commented 8 years ago

@ryankrabath-ws thanks for the PR.