search

meltwater / served

A C++11 RESTful web server library
MIT License
710 stars 173 forks source link

Bazel Adjustments (Imports, 0.7.0) #27

Closed promiseofcake closed 7 years ago

promiseofcake commented 7 years ago

When relying on served from another Bazel project, we run into issues due to the way the Boost skylark rules are imported:

$ bazel build //my/bazel/workspace:target
ERROR: /private/var/tmp/_bazel_lucas/413043c39fb284a3483c36335112944f/external/com_github_datasift_served/BUILD:7:1: error loading package '@com_github_datasift_served//third_party/boost': Every .bzl file must have a corresponding package, but 'third_party/boost' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to do anything except exist. and referenced by '@com_github_datasift_served//:served'
[...]
ERROR: Analysis of target '//my/bazel/workspace:target' failed; build aborted
INFO: Elapsed time: 0.302s
FAILED: Build did NOT complete successfully

Also adjusting issues with https://github.com/datasift/served/compare/master...promiseofcake:ljk/include-boost?expand=1#diff-90a27e9b8431b4e0ed187d43a290aa13 where if/then statements cannot be used outside of a function.

ERROR: /Users/lucas/Workspace/repos/promiseofcake/served/third_party/boost/tool.bzl:3:1: if statements are not allowed at the top level. You may move it inside a function or use an if expression (x if condition else y). Use --incompatible_disallow_toplevel_if_statement=false to temporarily disable this check.
ERROR: error loading package 'third_party/boost': Extension 'third_party/boost/tool.bzl' has errors
Jeffail commented 7 years ago

Awesome, thanks @promiseofcake!