search

melvinkcx / graphql-utilities

Oneshot middleware, query cost analysis, depth limiting, etc for graphql-core>=3.0 (formerly, graphql-core-next)
https://graphql-utilities.readthedocs.io/
MIT License
20 stars 1 forks source link

Graphene usage with GraphQL-utitlities #9

Closed vancouverwill closed 4 years ago

vancouverwill commented 4 years ago

Hey I saw your issue on Graphene as I was looking around for how to have request level middleware and evidently i'm not the only person who has had this issue :smile: https://github.com/graphql-python/graphene/issues/1117

Seems like your library solves that plus some other useful features but from the looks of https://github.com/melvinkcx/graphql-utilities/blob/a78299624356e53f2004bc56190642139b3f2ac3/setup.py#L42 it requires greater than graphql-core > 3 and latest stable version of Graphene requires graphql-core < 3

https://github.com/graphql-python/graphene/blob/3d0e460be166cbb7c3701a9d91030eb15c73e382/setup.py#L88

Just wondering if they were designed to work together or is this more of a replacement? Thanks and great work :+1:

melvinkcx commented 4 years ago

Thanks for showing interest.

Initially, this library was designed for the next version of Graphene which uses graphql-core > 3, which is expected to be released soon.

Coincidentally, the middleware decorator also works well with the current stable version.

I'm not considering to remove the constraint of requiring graphql-core > 3 since the other features will only work with graphql-core > 3.

Any suggestions are welcome :)

On Sat, Mar 7, 2020 at 2:46 AM vancouverwill notifications@github.com wrote:

Hey I saw your issue on Graphene as I was looking around for how to have request level middleware and evidently i'm not the only person who has had this issue 😄 graphql-python/graphene#1117 https://github.com/graphql-python/graphene/issues/1117

Seems like your library solves that plus some other useful features but from the looks of https://github.com/melvinkcx/graphql-utilities/blob/a78299624356e53f2004bc56190642139b3f2ac3/setup.py#L42 it requires greater than graphql-core > 3 and latest stable version of Graphene requires graphql-core < 3

https://github.com/graphql-python/graphene/blob/3d0e460be166cbb7c3701a9d91030eb15c73e382/setup.py#L88

Just wondering if they were designed to work together or is this more of a replacement? Thanks and great work 👍

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/melvinkcx/graphql-utilities/issues/9?email_source=notifications&email_token=AEBBQ4KZRFNJSNZ2XYGW7ATRGEZIZA5CNFSM4LDE4UE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITFS2EQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBBQ4PW4RPMNWPLJHCVF33RGEZIZANCNFSM4LDE4UEQ .

vancouverwill commented 4 years ago

Okay thanks for explaining and for the hard work on this. Will wait to Graphene 3.x is stable and use the decorator as is for now. Potentially could help with issues if they come up but all looks under control for now.