search

melwinVincent / ionic4-star-rating

Star Rating component for ionic-4 projects
23 stars 11 forks source link

Angular 9 Compilation Issue #13

Open psenechal opened 4 years ago

psenechal commented 4 years ago

Sorry to be the guy who upgrades to the new version of Angular within the first week and finds an issue. I'm sure it's on your radar to check for compatibility, but thought I would at least let you know the error I'm receiving when running a project with the module included:

ERROR in Failed to compile entry-point ionic4-star-rating (main as commonjs) due to compilation errors:
node_modules/ionic4-star-rating/dist/ionic4-star-rating.module.js:32:21 - error NG1010: Value at position 0 in the NgModule.declarations of StarRatingModule is not a reference: [object Object]
32       declarations: [
                       ~
33         StarRating
   ~~~~~~~~~~~~~~~~~~
34       ],
   ~~~~~~~
JeongJun-Lee commented 4 years ago

I made temporary component for a test of Angular 9. Until this component is updated, you can try it with https://github.com/JeongJun-Lee/ionic5-star-rating.