mem0ai / mem0

The Memory layer for your AI apps
https://mem0.ai
Apache License 2.0
21.85k stars 1.99k forks source link

bug: `docs_site` loader does not work #622

Open cachho opened 1 year ago

cachho commented 1 year ago

🐛 Describe the bug

Test code:

from embedchain import App
from embedchain.config import ChromaDbConfig, AppConfig

app = App(AppConfig(log_level="DEBUG"),chromadb_config=ChromaDbConfig(chroma_settings={"allow_reset": True}))
app.db.reset()
app.add("https://docs.zextras.com/carbonio-ce/html/general.html#what-is-product")
Dev-Khant commented 1 year ago

@deshraj @cachho Here when I checked for our docs it worked because quickstart was present in all_urls that are fetched in _get_child_links_recursive() of docs_site_loader.py.

image

But for the given URL in the above code. This current path == carbonio-ce/html/general.html in not present in all_urls and that's why no URL is selected and no data is loaded.

image image

So here to make sure that the given path is present in all_url can we append the current_path to the list? The link response is checked before, so there won't be any issue of a given link not working.

Dev-Khant commented 11 months ago

Hi @deshraj @cachho any update on this?