memaar92 / transcendence

MIT License
3 stars 0 forks source link

router doesn't refresh the expired access token when the page is manually refreshed --> user is logged out #89

Open Pommfritz0308 opened 21 hours ago

wrottger commented 18 hours ago

Has to do with /token/check not returning json["code"] = "token_not_valid"

wrottger commented 18 hours ago

that fixed it

memaar92 commented 18 hours ago

/token/check is not supposed to be returning json["code"] = "token_not_valid" (some time ago, we defined together that it should always return 200 and the info if user is logged in or not)

memaar92 commented 17 hours ago

@wrottger please check if your changes are not breaking something else in the app, because back then you explicitly asked for the 200 return code with logged-in or not json.

memaar92 commented 17 hours ago

@wrottger It is definitely breaking other stuff. E.g. when just navigate to localhost now (after a fresh build), you are getting a toast stating "Error: please log in". Also, it will break a check in the chatHandler.js Please test at least a bit before pushing

memaar92 commented 16 hours ago

thumbs down means you can replicate it or means you are not gonna test? (or something else?)