search

membermatters / MemberMatters

An open source membership, access and payments portal for makerspaces and community groups.
https://membermatters.org
MIT License
41 stars 23 forks source link

Fix broken build #160

Closed rechner closed 2 years ago

rechner commented 2 years ago

:wave: Hi there! I was having trouble getting the latest release, v2.8.0 to run due to a missing python dependency, with the v2.8.0 image that is in dockerhub (No module named 'python_http_client').

I also ran into some trouble building the docker image on my own machine, which died with this error:

mkdir: cannot create directory ‘/usr/src/logs’: File exists
The command '/bin/sh -c mkdir -p /usr/src/app/frontend && mkdir /usr/src/logs && mkdir /usr/src/data' returned a non-zero code: 1

This fixes both of these problems for me.

jabelone commented 2 years ago

Hey @rechner, thanks so much for the PR!

I've been very busy at work, and doing a lot of internal refactoring/dependency updates so I haven't had a chance to review your PR yet. I've explained more about what I'm currently working on in #166 for context. That will be done soon and I can take a proper look at your PR.

I appreciate your contribution, so thanks for your patience. :)

rechner commented 2 years ago

Hey @jabelone, wondering if you had another chance to look at this PR. The backend fixes here are pretty small and should get the docker builds going again (and save me some headache using a fork :sweat_smile:)

Let me know if there's anything I can do to reduce friction!

jabelone commented 2 years ago

Hey @rechner, sorry about the delay. I'll merge it in now to unblock you. I've been spending a lot of time working on #166 😅.