jabelone
commented
1 year ago Heya, thanks for taking the time to do up that PR!
Looks like you've found one of the few spots I haven't made internationalisation friendly yet (we're sending a hardcoded English message straight from the backend!). That being aside (which we can ignore for now), there's a few more places you'll likely have to make changes.
The frontend is what does most of the UI rendering. We use vue-i18n for internationalisation support on the frontend. Whilst we currently only support Australian English, most of the work is already done to support other locales (languages and number/date formatting etc.). An example of the frontend rendering a currency using vue-i18n is frontend/src/components/Billing/PlanCard.vue.
The proper way to do this is to implement it with the vue-i18n library as some currencies have more complex formats than a simple {{config.CURRENCY_SYMBOL}}{{amount}} can handle. I'm evidently guilty of doing this too, but generally string interpolation is a bad way of doing stuff like this.
After a quick look through that and other components, it looks like I had the foresight to use $n() from vue-i18n to render the front-end currencies. This means all it should take is for the frontend to update the current locale config and the currency should be rendered with the correct symbol and format. The documentation for the $n() method is here for reference and may be worth a read. This function basically takes your number and outputs it in the correct format depending on the locale that's set.
In essence, to properly support other currencies (and languages too) you'd have to:
1) add a way to auto detect the user's locale (seems pretty simple - and less work than having a user configurable option).
2) tell vue-i18n to use the user's locale (also seems reasonably simple).
3) that's it I think, although there may be a couple spots that need updating to use the $n() method.
Let me know how you go, and I may have a go at this if I find some time this week.
proffalken
In order to use Member Matters here in the UK, we need to be able to switch to GBP/£.
Given that we also don't want to maintain a UK-specific fork of the project, this PR should allow us to set a currency in the backend via Constance and have it cascade through the various screens automatically.
At present, the code has been updated and the currency variable is available within the Django Admin pages, however making a change to it does not appear to make a difference to the values displayed on screen.