Add Request and PathParamExtractor Interfaces - Githubissues

membrane-php / membrane-core

Membrane is a general purpose input validation library, supports both PHP Attributes and OpenAPI specifications

Other

3 stars 3 forks source link

Add Request and PathParamExtractor Interfaces #98

Closed charjr closed 1 year ago

charjr commented 1 year ago

Done

Adds RequestSpec Interface

RequestBuilder now takes RequestSpec
Request now implements RequestSpec
- Request and APISpec properties now private with getters to ensure Intefaces behave similarly
  - Several Classes refactored to call getters instead of accessing properties directly

Adds OpenAPIRequest implementing RequestSpec

Name might change

Adds ExtractsPathParameters Interface

PathMatcherFilter now takes ExtractsPathParameters
Interface requires a __toPHP() method to ensure compatibility with the PathMatcherFilter

Adds PathParameterExtractor implementing ExtractsPathParameters

TODO:

Certain methods like getOperationId are currently unused and untested.

Request Builder not currently testing compatibility with alternate Requests implementing RequestSpec.