search

membrane-php / membrane-laravel

Laravel integration for Membrane validation library.
Other
3 stars 2 forks source link

Default api_spec_file location could be openapi.yaml #17

Closed philsturgeon closed 7 months ago

philsturgeon commented 7 months ago

The README makes it sound like publishing the config is just about updating defaults, but really its required for the main use case unless you happen to have a api/pets.yaml. 

# config/membrane.php

    'api_spec_file' => base_path() . '/api/pets.yaml',

Could this be a reasonable default like api/openapi.yaml? That would then work out of the box for a lot more people, especially as OAS recommends openapi.yaml as the filename, then the only issue is what folder is it in, and api isn't an unreasonable one.

charjr commented 7 months ago

I agree, will implement that shortly