search

membrane / soa-model

Toolkit and Java API for WSDL, WADL and XML Schema.
http://www.membrane-soa.org/soa-model/
Apache License 2.0
93 stars 73 forks source link

Difference for a new Element with minOcurs=1 in a Choice is considered safe #172

Closed ithena closed 11 years ago

ithena commented 11 years ago

Should this Difference not be breaks=true?

keshavarzi commented 11 years ago

Not necessary! From the clients point of view a new element is added to a choice, which could be ignored further because of 'choice'. The interface would still work.

keshavarzi commented 11 years ago

The other thing is, it depends on the point of view! If you are the server and an element is added to the choice, the client could use is and the old interface would be broken.

keshavarzi commented 11 years ago

Btw it would be better to talk about 'request' and 'response' instead of 'client' and 'server'!

ithena commented 11 years ago

Request and response is indeed more clear. We might, if time permits, try to report the breaks/safe value of a difference different depending if it occurs in the context of a request or a response. But we first need to look into how we could easily do this with the current soa-model lib.

keshavarzi commented 11 years ago

There is an exchange property in class Difference. This is used to store if the difference is related to an input, output or fault. This could be used for your purpose.