The Pull Request aims to make the "Ooops, trn your device... " screen a little more accurate in terms of when it should pop out.
The proposed solution is that we check if a device is a smartphone (not a tablet - tablets should behave like desktops in terms of most UI) by:
Finding out if it has a coarse pointer.
Checking the width of a visual viewport:
if it's under MOBILE_WIDTH_BANDWIDTH then it is considered a smartphone
if not we check if the width is under MAX_MOBILE_WIDTH_BANDWIDTH and then check if he screen is horizontal.
The behaviour of the "Turn your device..." screen works as expected on most smartphones and tablets tested on chrome devtools. There may be some uncovered cases like a laptop with touchscreen and small viewport (eg. when minimising the width of a window). Those should be tested as well.
Besides, some small readability changes have been done..
The Pull Request aims to make the "Ooops, trn your device... " screen a little more accurate in terms of when it should pop out.
The proposed solution is that we check if a device is a smartphone (not a tablet - tablets should behave like desktops in terms of most UI) by:
MAX_MOBILE_WIDTH_BANDWIDTHand then check if he screen is horizontal.The behaviour of the "Turn your device..." screen works as expected on most smartphones and tablets tested on chrome devtools. There may be some uncovered cases like a laptop with touchscreen and small viewport (eg. when minimising the width of a window). Those should be tested as well.
Besides, some small readability changes have been done..