search

membraneframework / membrane_core

The core of the Membrane Framework, advanced multimedia processing framework
https://membrane.stream
Apache License 2.0
1.22k stars 34 forks source link

Add RTSP server #683

Open varsill opened 7 months ago

varsill commented 7 months ago

Currently, the membrane_rtsp package (https://github.com/membraneframework/membrane_rtsp) contains only RTSP client, capable of receiving RTSP messages. Adding the corresponding RTSP server functionality (so that the user would be able to send RTSP messages) should be problematic and definitely it would be helpful, because we then could use such a server e.g. in our rtsp_to_hls demo. Apart from them, I believe the package name should be converted to ex_rtsp to follow our naming conventions.

varsill commented 7 months ago

It has turned out that there is already an implementation of a simple RTSP server in Jellyfish. I slightly modified it and added it to the rtsp_to_hls demo: https://github.com/membraneframework/membrane_demo/blob/master/rtsp_to_hls/server.exs

mat-hek commented 7 months ago

@varsill should we close this then?

varsill commented 6 months ago

As discussed - closing since no further development is required at this moment. In the future, we might want to rewrite the RTSP server in such a manner, that each message could be responded to within a callback.

gBillal commented 5 months ago

Hi @varsill @mat-hek Since I also need an RTSP server, I decided to create a fork of membrane_rtsp taking inspiration from the server example mentioned in this issue. This is the work done so far. It's not yet finished as I'm trying to wrap my head around the RFC. If you think we can add it to membrane_rtsp I'll create a PR.

mat-hek commented 5 months ago

Hi, it looks good to me! Feel free to open a PR, thanks ;)