membraneframework / membrane_core

The core of the Membrane Framework, multimedia processing framework written in Elixir
https://membrane.stream
Apache License 2.0
1.31k stars 39 forks source link

[Bundlex] Reconsider public API #721

Closed Noarkhh closed 8 months ago

Noarkhh commented 9 months ago

Right now functions Bundlex.get_target/0 and Bundlex.platform/0 aren't clearly distinguished and it's not really clear when which one should be used. Moreover I believe it's worth considering whether one of these functions isn't redundant, since they use :erlang.system_info(:system_architecture) and :os.type() respectively and it's not really clear when one is more useful than the other.

Also from these two only Bundlex.platform/0 gives information about crosscompilation for nerves, so that functionality could be extended to Bundlex.get_target/0 which is used by Precompiled Dependency Provider. That would stop it from downloading precompiled builds for wrong target (right now when crosscompiling precompiled dependencies need to be disabled manually, related discord thread).