search

membraneframework / membrane_core

The core of the Membrane Framework, multimedia processing framework written in Elixir
https://membrane.stream
Apache License 2.0
1.29k stars 36 forks source link

[membrane_file_plugin] Tests fail with elixir v1.16.0 #774

Closed kidq330 closed 5 months ago

kidq330 commented 6 months ago

Since Mix.Shell.Quiet is not total in its functionality, the new behaviour of Mix.install can sometimes leak logs, making it harder to use %Membrane.File.Sink{location: :stdout}. In particular, the warnings that show up when compiling the elixir-rational library, which is a dependency of membrane_core.

Fixing the warnings also fixes the leaky logs encountered in file_plugin's tests (but I would expect more cases like this to crop up). I would consider to also inspect whether the leaks stem from a non-homogenous way of logging in the implementation of Mix.install itself. I mentioned this particular case as a side note here, but have not received an explicit response.

A PR has been opened in elixir-rational, let's hope it is noticed soon.

Blocks #773.

kidq330 commented 6 months ago

I guess since the PR's destination is elixir-rational's master branch directly, it is considered to be outside the organisation 😵‍💫 linking here instead. Whenever it is merged, the next step would be to bump :ratio in membrane_core

mat-hek commented 5 months ago

The PR is merged, so the tests should stop failing once we update the core to 1.1.0