search

membraneframework / membrane_core

The core of the Membrane Framework, advanced multimedia processing framework
https://membrane.stream
Apache License 2.0
1.22k stars 34 forks source link

RTMP plugin does not deliver end_of_stream on DeleteMessage, as it is not parsing it #789

Closed dmorn closed 2 months ago

dmorn commented 2 months ago

This line here https://github.com/membraneframework/membrane_rtmp_plugin/blob/4e913b6a0ad0ac3c65baed97ad67f7e14bb85d82/lib/membrane_rtmp_plugin/rtmp/source/message_handler.ex#L236

Is never going to be called as the mapping of the message.ex module

  @amf_command_to_module %{
    "connect" => Messages.Connect,
    "releaseStream" => Messages.ReleaseStream,
    "FCPublish" => Messages.FCPublish,
    "createStream" => Messages.CreateStream,
    "publish" => Messages.Publish,
    "@setDataFrame" => Messages.SetDataFrame,
    "onMetaData" => Messages.OnMetaData
  }

is missing [FCUnpublish deleteStream]. PR coming to conform with this issue