Closed kevinschweikert closed 1 year ago
Would it make sense to also mark them as optional, so when you use this package in another mix project, the version is not relevant? like this:
# Testing
{:mockery, "~> 2.1", runtime: false, only: :test, optional: true},
{:membrane_file_plugin, "~> 0.15.0", only: :test, optional: true},
@kevinschweikert I believe only: :test
works that way - now when you have membrane_ffmpeg_swresample_plugin
as a dependency, it should work no matter what version of membrane_file_plugin
you have in your project. Regarding mockery, AFAIK it cannot be made test only, unfortunately.
@mat-hek Thanks for the clarification. I updated my branch to mark the dependency as a test dependency. Do you want me to open another PR for this?
I've already marked it, I thought it's no point in making you do this. Sorry for the confusion. The plugin is already released as 0.17.3 ;)
Hey,
I currently try to build a pipeline where I need the file plugin 0.15 with the
seekable?: true
feature, which is only available in the newest version. This package depends on an older version, so I bumped the dependency version and updated theex_doc
andmembrane_file_plugin
versions.The tests run still fine, so I thought this could be helpful to you.
Cheers Kevin