memcachier / memjs

A memcache client for node using the binary protocol and SASL authentication
MIT License
197 stars 52 forks source link

Possible bug in signature check #173

Closed nfriedly closed 10 months ago

nfriedly commented 1 year ago

I'm not certain, but I think you intended to have a typeof here:

https://github.com/memcachier/memjs/blob/f10b26006e1a40394dc192f9edd628c0ec43189a/lib/memjs/memjs.js#L416-L417

-  if(callback === undefined && options !== 'function') {
+  if(callback === undefined && typeof options !== 'function') {
saschat commented 1 year ago

You are right. That is a bug. Will fix this shortly.

saschat commented 10 months ago

Fixed in version 1.3.2.