search

memcachier / memjs

A memcache client for node using the binary protocol and SASL authentication
MIT License
197 stars 52 forks source link

Fixes set(...) not being backwards compatible on null callback. #93

Closed safeer closed 7 years ago

safeer commented 7 years ago

Clients still using the old argument ordering with a null or undefined callback are broken since the API determines old vs new usage using typeof options for which null is a valid case. This fix also detects the old API usage in the case that callback is the expiration interval.

alevy commented 7 years ago

Ah, so basically if someone used set without a callback. Great! Thanks! Will mint a minor version bumb