memeLab / Jandig

Web AR served as a PWA to enable artists to expose and share virtual content in real spaces.
http://jandig.app
GNU General Public License v3.0
55 stars 21 forks source link

As an artist, I want to change the size, proportion and position of Objects, so I can create more immersive content #220

Open vjpixel opened 5 years ago

vjpixel commented 5 years ago

Some objects are created as rectangular GIFs. The user needs to be able to correct this on the platform.

vjpixel commented 5 years ago

This issue is impacting the exhibition on Sesc right now and will impact the one on EBAC.

pablodiegoss commented 5 years ago

How do you suggest we solve this? Post an example of the problem here and how you want it to be like

vjpixel commented 5 years ago

I want to be able to change the same parameters that were possible to change by hand on the code.

Don't have a way to make a screenshot now (no makers or nearby friends), but you can check Sexy na Janela ti understand the problem.

vjpixel commented 5 years ago

I'm adding a screenshot now. Tokusatsu, Robô Rodas, Sexy na Janela, Plan9 and Robô Peixe are with wrong proportions.

Screenshot from 2019-07-10 12-20-38

vjpixel commented 4 years ago

do you need any more information @pablodiegoss ?

pablodiegoss commented 4 years ago

The thumbnails are set to be shown in 50x50 in this grid. It is just a CSS problem, should work fine inside the app and camera as we use the marker on its real size and do not scale or resize them.

This issue is actually related to be able to edit the position/scale/rotation of an Object being shown on a marker. Like we have coded Samurai being a little bigger than the marker, how do we make a UI to change this params for each marker? Which kind of buttons do we implement for the user to update position/rotation/scale of an object and understand the final result that is happening to his Artwork? Thats our problem.

vjpixel commented 4 years ago

I think the best solution to solve this issue in the short term is:

For proportion To calculate the proportion of the Object based on its resolution, and to fit the shorter side in the marker (so, if the Object is in portrait format, it should fit the sides on the sides on the sides of the marker). There's no user interaction here.

For size Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

To make easier to understand the settings, we can improve this manual and put this information, including information about to test and come back to change these settings.

pablodiegoss commented 4 years ago

For size Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

Both values for scale and position are 3d vectors, since we work in a 3d virtual scene to position objects. Then we have to ignore scales like (1x, 1.5y ,1z) to have scales of only equal values (1,1,1) if we use this kind of numerical field. For position then Z would be unused too. Horizontal would change the X and Vertical the Y but a (0,0) would represent the center of a marker or the left upper corner?.

vjpixel commented 4 years ago

Using scale and position as you're describing seems to be good.

We should use the center of the marker as (0,0).

vjpixel commented 4 years ago

@anacforcelli it still doesn't match the requisites below.

You can have the Scale and Rotation code commented. The scale needs to be calculated automatically, following the rules below.

Also, to solve this issue a user needs to be able to edit the content after it's published, so it can adjust the values until the content is in the desired position.

One solution to do this is to implement an "edit" button on Object list on the My Stuff tab.

Tip: the Z now is the Size described below.

I think the best solution to solve this issue in the short term is:

For proportion To calculate the proportion of the Object based on its resolution, and to fit the shorter side in the marker (so, if the Object is in portrait format, it should fit the sides on the sides on the sides of the marker). There's no user interaction here.

For size Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

To make easier to understand the settings, we can improve this manual and put this information, including information about to test and come back to change these settings.

anacforcelli commented 4 years ago

Checking the scope: -Make "help" icons that show a text box near the cursor when the user hovers the mouse over them; -Objects on item-lists show on scale instead of fixed 50x50; -Edit an object's attributes after it was uploaded via an edit button that leads to an edit page.

vjpixel commented 4 years ago

The objects must have the Height or Width as 50px, and the other side must be smaller. This way, the larger side is 50px.

OK?

anacforcelli commented 4 years ago

yes, that is check

anacforcelli commented 4 years ago

I am doing a teamwork with @hockpond to develop the edit pages for artworks and objects, which also regard issue #307, in such a way that the user won't be prompted to input everything about the artwork/object they are editing again.