search

memeLab / Jandig

Web AR served as a PWA to enable artists to expose and share virtual content in real spaces.
http://jandig.app
GNU General Public License v3.0
56 stars 21 forks source link

As an user, I want to take pictures and share them, so I can show my friends what I'm seeing. #36

Open rodrigocam opened 6 years ago

rodrigocam commented 6 years ago

Create a way to save and share images/videos inside ARte and share this content in different medias.

vjpixel commented 5 years ago

We tried to do that, but the result wasn't satisfactory.

@pablodiegoss @rodrigocam can you please describe the problems you found when you worked on this?

pablodiegoss commented 5 years ago

Taking pictures inside the params of Jandig isn't a normal "screenshot". We need to capture the 3D scene with the virtual objects and the camera stream, we achieved that using the data from our canvas, but the WebRTC getusermedia camera delivers an image that is rotated 90degrees, as we screenshot the canvas we get a base64 encoding, so we need to rotate base64 data to save it in the correct orientation. (Rotating the base64 encoding led to some infinite loop where it download hundreds of images on your device)

Besides that, in PWA the "take a photo" button was really a download button, so when the user clicks on the button we get the 3D canvas and transform it into a link with the data making the user download it, but this solution often returns a "network error" or "unknown" error in some devices that we couldn't track and debug why.

The result we got with this feature was saving a rotated photo on the device and sometimes the user got errors that didn't made sense.

luccaepp commented 4 years ago

@vjpixel please review

vjpixel commented 4 years ago

This issue needs #36 to be properly tested.

vjpixel commented 3 years ago

This is a very old feature we want to implement. We tried many times without success.