search

memelopez / toDoList-webpack-mv

A simple HTML list of To Do tasks using webpack and served by a webpack dev server.
MIT License
1 stars 0 forks source link

Do I follow JavaScript best practices? #5

Closed memelopez closed 2 years ago

memelopez commented 2 years ago

https://github.com/memelopez/toDoList-webpack-mv/blob/8c7528ede4f6fe9cbd6d31ba3d3faa4435b61ee0/src/index.js#L70

this could be declared globally to avoid repetition.

https://github.com/memelopez/toDoList-webpack-mv/blob/8c7528ede4f6fe9cbd6d31ba3d3faa4435b61ee0/src/index.js#L40-L41

this could also be a separate method

https://github.com/memelopez/toDoList-webpack-mv/blob/8c7528ede4f6fe9cbd6d31ba3d3faa4435b61ee0/src/modules/ui.js#L98-L107

try inserting just one <ul> for the add task method, and for the update. for the remove method, try removing just one element from the UI.