search

memfault / interrupt

A community for embedded software makers.
https://interrupt.memfault.com
Other
462 stars 131 forks source link

content: publish schematic checklist #487

Closed bahildebrand closed 2 months ago

cloudflare-pages[bot] commented 2 months ago

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d6aa1c
Status:⚡️  Build in progress...

View logs

bahildebrand commented 2 months ago

@schultetwin I made some minor spelling changes, but otherwise looks good to go. Can I get your eyes on this?

schultetwin commented 2 months ago

The changes look great to me! Should I make the changes? Or should I have y'all merge the PR and then make more?

Mark

On Tue, Jul 16, 2024 at 3:07 PM Gillian Minnehan @.***> wrote:

@.**** commented on this pull request.

In _posts/2024-07-02-schematic-review-checklist.md https://github.com/memfault/interrupt/pull/487#discussion_r1680116839:

@@ -1,45 +1,45 @@

Last couple things (making a comment to track them):

  • update date to 7/17
  • run prettier npx prettier --prose-wrap always --write [post] -- I've been running this manually lately but Noah has a PR up to add to it to the precommit hook. I would put this formatting in a separate commit since it will make changes hard to see.

— Reply to this email directly, view it on GitHub https://github.com/memfault/interrupt/pull/487#pullrequestreview-2181391564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCS6UMAOZPTMPAN736OG3ZMWKSPAVCNFSM6AAAAABKHU2N3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBRGM4TCNJWGQ . You are receiving this because you were mentioned.Message ID: @.***>

gminn commented 2 months ago

The changes look great to me! Should I make the changes? Or should I have y'all merge the PR and then make more? Mark

@schultetwin Nope we'll handle them!