search

memfault / memfault-firmware-sdk

Memfault SDK for embedded systems. Observability, logging, crash reporting, and OTA all in one service. More information at https://docs.memfault.com.
https://memfault.com
Other
149 stars 75 forks source link

ports: zephyr: remove non-existing Kconfig option #25

Closed gmarull closed 2 years ago

gmarull commented 2 years ago

OPENOCD_SUPPORT was deprecated in favor of DEBUG_THREAD_INFO in Zephyr v2.6. OPENOCD_SUPPORT is no longer part of Zephyr, so remove it. Note that DEBUG_THREAD_INFO was already selected.

chrisc11 commented 2 years ago

OPENOCD_SUPPORT was deprecated in favor of DEBUG_THREAD_INFO in Zephyr v2.6. OPENOCD_SUPPORT is no longer part of Zephyr, so remove it. Note that DEBUG_THREAD_INFO was already selected.

Thanks for the report @gmarull! One challenge we face is that some memfault users are on forked releases of Zephyr (for example, an LTS release) where OPENOCD_SUPPORT is required and still updating the memfault-firmware-sdk. The alert that prints about OPENOCD_SUPPORT being deprecated on newer builds is annoying though! We'll take a look at how to silence the warning and maintain backward compatibility

gmarull commented 2 years ago

Maybe you can define a dummy symbol on your side then? @tejlmand can you comment on this one?

tejlmand commented 2 years ago

Maybe you can define a dummy symbol on your side then? @tejlmand can you comment on this one?

I think adding a dummy symbol on this is in principle wrong. It could be that in other cases you must for example depends on a removed or renamed symbol. Or that you want to do A in one release, but B in another.

So maybe the best is to have release specific Kconfig fragments and then include those based on the Zephyr version in use. Like, if(Zephyr version <= 2.6.0) .... Let me come up with a small proposal.

I think this is a good use-case, valuable for other projects supporting different Zephyr revisions.

tejlmand commented 2 years ago

added a proposal here: https://github.com/memfault/memfault-firmware-sdk/pull/26 However, this proposal relies on a feature introduced with Zephyr v2.5.0.

tejlmand commented 2 years ago

The alert that prints about OPENOCD_SUPPORT being deprecated on newer builds is annoying though!

and such situations are avoided with the proposal in #26

chrisc11 commented 2 years ago

The alert that prints about OPENOCD_SUPPORT being deprecated on newer builds is annoying though!

and such situations are avoided with the proposal in #26

Thanks for the suggestions @tejlmand @gmarull -- I see on Zephyr develop the warning has now been removed completely so this no longer shows. Just for reference, was there a compiler error you were seeing as a result of this toggle or just trying to remove the warning?

gmarull commented 2 years ago

We have a mechanism that checks if any referenced Kconfig symbol is present or not. We are currently observing a warning when using Memfault because OPENOCD_SUPPORT doesn't exist since Zephyr 3.0.

gmarull commented 2 years ago

@chrisc11 ping

chrisc11 commented 2 years ago

We have a mechanism that checks if any referenced Kconfig symbol is present or not. We are currently observing a warning when using Memfault because OPENOCD_SUPPORT doesn't exist since Zephyr 3.0.

Thanks for the context, we published an update in 0.29.1 to avoid this warning from showing up so marking this as closed