search

memfault / memfault-firmware-sdk

Memfault SDK for embedded systems. Observability, logging, crash reporting, and OTA all in one service. More information at https://docs.memfault.com.
https://memfault.com
Other
149 stars 75 forks source link

zephyr: z_NmiHandlerSet used in port is gone #49

Closed mbolivar-nordic closed 1 year ago

mbolivar-nordic commented 1 year ago

Zephyr commit https://github.com/zephyrproject-rtos/zephyr/commit/77d2490164cbb5dbdd8dee9c0787204b0006f635 renamed this function.

This is breaking the build at least in ports/zephyr/v2.4/memfault_fault_handler.c:

static int prv_install_nmi_handler() {
  extern void z_NmiHandlerSet(void (*pHandler)(void));
  z_NmiHandlerSet(MEMFAULT_EXC_HANDLER_NMI);
  return 0;
}

I'm not sure what the right fix is -- perhaps a new ports/zephyr/v3.4 which uses the new name, z_arm_nmi_set_handler?

mbolivar-nordic commented 1 year ago

This is affecting the nRF Connect SDK.

mbolivar-nordic commented 1 year ago

@maxd-nordic maxd-nordic linked a pull request Apr 19, 2023 that will close this issue rename z_NmiHandlerSet to z_arm_nmi_set_handler #50

Note that this is just a workaround; the real fix should IMO come in the memfault SDK itself.

noahp commented 1 year ago

@mbolivar-nordic apologies for the delay, we should have a release out shortly with this fixed!

noahp commented 1 year ago

We've just shipped a release with a fix for this, thank you for posting! https://github.com/memfault/memfault-firmware-sdk/releases/tag/0.43.1