zephyr: `memfault_zephyr_log_backend_disable` called even without `CONFIG_MEMFAULT_LOGGING_ENABLE`

memfault / memfault-firmware-sdk

Memfault SDK for embedded systems. Observability, logging, crash reporting, and OTA all in one service. More information at https://docs.memfault.com.

https://memfault.com

Other

149 stars 75 forks source link

zephyr: `memfault_zephyr_log_backend_disable` called even without `CONFIG_MEMFAULT_LOGGING_ENABLE` #56

Closed JordanYates closed 1 year ago

JordanYates commented 1 year ago

memfault_zephyr_log_backend_disable is called here: https://github.com/memfault/memfault-firmware-sdk/blob/73ec7b7c020d9183f264c45c0fa3d3f2b9238aa1/ports/zephyr/common/memfault_platform_core.c#L52

Even when CONFIG_MEMFAULT_LOGGING_ENABLE=n, resulting in compilation errors.

noahp commented 1 year ago

@JordanYates thanks for reporting, this will be fixed ASAP!

noahp commented 1 year ago

@JordanYates FYI this is fixed in SDK v1.1.2, published now: https://github.com/memfault/memfault-firmware-sdk/releases/tag/1.1.2

Thanks again for reporting, and let us know if there's any problem!