memfault / memfault-firmware-sdk

Memfault SDK for embedded systems. Observability, logging, crash reporting, and OTA all in one service. More information at https://docs.memfault.com.
https://memfault.com
Other
149 stars 75 forks source link

RFC: Zephyr: In PR #60031 aarch32 directory in favor of cmsis_core.h #64

Closed kmeinhar closed 1 year ago

kmeinhar commented 1 year ago

https://github.com/zephyrproject-rtos/zephyr/pull/60031

This is required for current main and upcoming Zephyr release v.3.5 (Scheduled for 2023/10/20).

Probably missed some locations. This is mostly to unblock our CI.

This is also not compatible with current version 3.4 or early. Needs a proper fix.

noahp commented 1 year ago

Wonderful, and great timing! we've just released SDK version 1.3.0 which should address the problems you found. I'm going to rework it a bit to use the <cmsis_core.h> header, which is a nicer approach, thank you for suggesting it!