`memfault_platform_coredump_save_begin` is documented as being weak no-op, but is not in ESP-IDF

memfault / memfault-firmware-sdk

Memfault SDK for embedded systems. Observability, logging, crash reporting, and OTA all in one service. More information at https://docs.memfault.com.

https://memfault.com

Other

149 stars 75 forks source link

`memfault_platform_coredump_save_begin` is documented as being weak no-op, but is not in ESP-IDF #77

Closed finger563 closed 1 week ago

finger563 commented 2 weeks ago

Per the documentation and within the base sdk memfault_platform_coredump_save_begin() is listed as a weakly defined symbol that can be overridden by user code.

However, the esp-idf platform port overrides this here.

noahp commented 2 weeks ago

Hi @finger563 , you're correct! We'll update the SDK to make that change. Do you have a timeline for when you'd need an SDK release with the fix?

finger563 commented 2 weeks ago

We have some platform integration deliverable timelines which are due by Nov 11, though of course the earlier the better for completing the integration and testing.

noahp commented 2 weeks ago

Thanks @finger563 ! We'll schedule an SDK release for this week, I'll post back here when it's shipped.

gminn commented 1 week ago

@finger563 This has been addressed in v1.16.0, the release that went out today. Please review the Changelog here for details, and let us know if you have any other questions!