search

memflow / memflow-kvm

Linux kernel module for memflow's KVM connector
MIT License
36 stars 8 forks source link

cargo vendor failing on next due to abi_stable #6

Closed weewoo22 closed 2 years ago

weewoo22 commented 2 years ago

I'm packaging d41ba2162d92b38a91d822c8776836bcb1d65722 for my OS but the build is failing when generating the lock file:

$ git checkout next
Branch 'next' set up to track remote branch 'next' from 'origin'.
Switched to a new branch 'next'

$ cargo vendor
    Updating crates.io index
    Updating git repository `https://github.com/memflow/memflow.git`
    Updating git repository `https://github.com/rodrimati1992/abi_stable_crates`
    Updating git repository `https://github.com/h33p/cglue.git`
  Downloaded typed-arena v2.0.1
  Downloaded tstr_proc_macros v0.2.2
  Downloaded bit_field v0.10.1
  Downloaded abi_stable_shared v0.10.3
  Downloaded time-macros v0.2.3
  Downloaded bindgen v0.58.1
  Downloaded tstr v0.2.2
  Downloaded ahash v0.7.6
  Downloaded repr_offset v0.2.1
  Downloaded goblin v0.4.3
  Downloaded as_derive_utils v0.10.3
  Downloaded volatile v0.4.4
  Downloaded x86_64 v0.14.6
  Downloaded abi_stable v0.10.3
  Downloaded darling_core v0.13.0
  Downloaded darling v0.13.0
  Downloaded scroll_derive v0.10.5
  Downloaded proc-macro-crate v1.1.0
  Downloaded shlex v1.1.0
  Downloaded humantime v2.1.0
  Downloaded core_extensions_proc_macros v1.5.1
  Downloaded paste v1.0.6
  Downloaded parking_lot_core v0.8.5
  Downloaded thiserror-impl v1.0.30
  Downloaded time v0.3.5
  Downloaded serde_json v1.0.72
  Downloaded simple_logger v1.15.0
  Downloaded plain v0.2.3
  Downloaded generational-arena v0.2.8
  Downloaded parking_lot v0.11.2
  Downloaded itertools v0.10.1
  Downloaded lock_api v0.4.5
  Downloaded hashbrown v0.11.2
  Downloaded fixed-slice-vec v0.8.0
  Downloaded instant v0.1.12
  Downloaded env_logger v0.8.4
  Downloaded darling_macro v0.13.0
  Downloaded rangemap v0.1.14
  Downloaded clang-sys v1.3.0
  Downloaded thiserror v1.0.30
  Downloaded abi_stable_derive v0.10.3
  Downloaded libloading v0.7.2
  Downloaded core_extensions v1.5.2
  Downloaded 43 crates (2.0 MB) in 2.03s
error: failed to sync

Caused by:
  found duplicate version of package `abi_stable v0.10.3` vendored from two sources:

    source 1: registry `https://github.com/rust-lang/crates.io-index`
    source 2: https://github.com/rodrimati1992/abi_stable_crates#f5a18cc2
weewoo22 commented 2 years ago

Fixed by 1166d416f92ca4b2be64225d9c9bd8eda37b209a as I was writing this issue

h33p commented 2 years ago

It was a bit of a my mess up. The commit now has been revereted, I instead added necessary changes to memflow and cglue repos so that patching is not needed.

weewoo22 commented 2 years ago

See https://github.com/memflow/memflow/commit/2fb2b8e968765cad5c3a102cd972d137c0ddad65#r60938208 regarding fixing this from the memflow side of things

h33p commented 2 years ago

I'm incredibly careful. Thanks for bringing this to my attention!