search

memflow / memflowup

Setup tool for memflow and it's components
https://memflow.io
MIT License
23 stars 2 forks source link

Manual connector delete #7

Closed ko1N closed 7 months ago

ko1N commented 8 months ago

If connectors are deleted by the user theyll still be seen as "installed". The filename should be checked in this case and they should be removed from the registry.

h33p commented 8 months ago

I disagree with the exact solution. I wouldn't automatically clean the registry just because one file is missing. I would mark the connector as installed (broken) or installed (externally deleted) that the users could then run uninstall or fix command to reconcile the state.

ko1N commented 7 months ago

This is now solved in memflowup 0.2.0 - If a connector is installed manually without an appropriate .meta file it will be caught by memflowup plugins clean and deleted. If the user wants to install the plugin properly from source we can do:

memflowup build https://github.com/memflow/memflow-coredump

to download and install from a git repository (even non official ones), or

memflowup build --path .

to properly install a connector from a locally checked out repo.