search

memfreeme / memfree

MemFree - Hybrid AI Search Engine & AI Generate UI
https://www.memfree.me
MIT License
785 stars 101 forks source link

Fix the compile warnings #11

Open ahaapple opened 2 days ago

ahaapple commented 2 days ago

After run bun run build, there are some warnings:

./components/ui/resizable.tsx
13:16  Warning: Classnames 'h-full, w-full' could be replaced by the 'size-full' shorthand!  tailwindcss/enforces-shorthand
39:23  Warning: Classnames 'h-2.5, w-2.5' could be replaced by the 'size-2.5' shorthand!  tailwindcss/enforces-shorthand
Riyan-Mo commented 10 hours ago

Can you please assign this to me?

ahaapple commented 10 hours ago

@Riyan-Mo Thank you very much, looking forward to your PR. You can modify the warning related to tailwind css first.

Riyan-Mo commented 10 hours ago

@ahaapple I have opened a pull request to resolve this issue: https://github.com/memfreeme/memfree/pull/24

ahaapple commented 9 hours ago

@Riyan-Mo Thank you for your contribution. If you execute bun run build in the frontend directory, you will find more tailwindcss warnings. If you are interested, you can continue to submit PR. Thank you.

./components/ui/calendar.tsx
28:21  Warning: Classnames 'h-7, w-7' could be replaced by the 'size-7' shorthand!  tailwindcss/enforces-shorthand
40:14  Warning: Classnames 'h-9, w-9' could be replaced by the 'size-9' shorthand!  tailwindcss/enforces-shorthand
57:50  Warning: Classnames 'h-4, w-4' could be replaced by the 'size-4' shorthand!  tailwindcss/enforces-shorthand
58:52  Warning: Classnames 'h-4, w-4' could be replaced by the 'size-4' shorthand!  tailwindcss/enforces-shorthand

./components/ui/chart.tsx
181:20  Warning: The arbitrary class 'min-w-[8rem]' could be replaced by 'min-w-32'  tailwindcss/no-unnecessary-arbitrary-value
196:28  Warning: Classnames '[&>svg]:h-2.5, [&>svg]:w-2.5' could be replaced by the '[&>svg]:size-2.5' shorthand!  tailwindcss/enforces-shorthand
295:26  Warning: Classnames '[&>svg]:h-3, [&>svg]:w-3' could be replaced by the '[&>svg]:size-3' shorthand!  tailwindcss/enforces-shorthand
303:19  Warning: Classnames 'h-2, w-2' could be replaced by the 'size-2' shorthand!  tailwindcss/enforces-shorthand

./components/ui/checkbox.tsx
15:16  Warning: Classnames 'h-4, w-4' could be replaced by the 'size-4' shorthand!  tailwindcss/enforces-shorthand
24:14  Warning: Classnames 'h-4, w-4' could be replaced by the 'size-4' shorthand!  tailwindcss/enforces-shorthand

./components/ui/command.tsx
17:16  Warning: Classnames 'h-full, w-full' could be replaced by the 'size-full' shorthand!  tailwindcss/enforces-shorthand
32:18  Warning: Classnames '[&_[cmdk-input-wrapper]_svg]:h-5, [&_[cmdk-input-wrapper]_svg]:w-5' could be replaced by the '[&_[cmdk-input-wrapper]_svg]:size-5' shorthand!  tailwindcss/enforces-shorthand
32:18  Warning: Classnames '[&_[cmdk-item]_svg]:h-5, [&_[cmdk-item]_svg]:w-5' could be replaced by the '[&_[cmdk-item]_svg]:size-5' shorthand!  tailwindcss/enforces-shorthand
45:13  Warning: Classnames 'h-4, w-4' could be replaced by the 'size-4' shorthand!  tailwindcss/enforces-shorthand
Riyan-Mo commented 5 hours ago

Yes thank you