[master < T] Pydantic v2 - Githubissues

memgraph / gqlalchemy

GQLAlchemy is a library developed with the purpose of assisting in writing and running queries on Memgraph. GQLAlchemy supports high-level connection to Memgraph as well as modular query builder.

https://pypi.org/project/gqlalchemy/

Apache License 2.0

226 stars 32 forks source link

[master < T] Pydantic v2 #278

Closed as51340 closed 1 year ago

as51340 commented 1 year ago

Description

Bumped pydantic to v2.3.0

Pull request type

Please delete options that are not relevant.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring with functional or API changes
[ ] Refactoring without functional or API changes
[x] Build or packaging related changes
[ ] Documentation content changes
[ ] Other (please describe):

Related issues

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

[ ] Core feature implementation
[ ] Tests
[ ] Code documentation
[ ] Documentation on gqlalchemy/docs

######################################

as51340 commented 1 year ago

@antepusic it is still not working, problems with some type

katarinasupe commented 1 year ago

@as51340 we should be careful with migration to Pydantic v2 and how that affects our users and us. This guide might help: https://docs.pydantic.dev/latest/migration/#migration-guide. The conclusion of this PR might also be us not moving to Pydantic v2 for now (if you conclude it's too much work for now). But, notice also what users suggested in the linked issue: https://github.com/memgraph/gqlalchemy/issues/257#issuecomment-1685718099 . I also found this in their migration guide that might help: https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features

katarinasupe commented 1 year ago

There is also a tool that might help if we migrate: https://docs.pydantic.dev/latest/migration/#code-transformation-tool