memgraph / helm-charts

Helm charts for deploying Memgraph, an open-source in-memory graph database.

https://memgraph.github.io/helm-charts/

Apache License 2.0

13 stars 9 forks source link

Memgraph platform #13

Closed tewnut closed 4 months ago

tewnut commented 7 months ago

Add memgraph-platform chart.
Upgrade memgraph chart default version to 2.13.0

antejavor commented 7 months ago

Hi @tewnut, thanks a lot for opening a PR 🚀 . I will review this in the next few days!

CarlEkerot commented 7 months ago

Been using this somewhat successfully the last week or so. I am not knowledgeable enough in Helm charts to give a proper review, but here are some pointers as a user:

Deploying this from IaC, it would be nice to (optionally) provide existing volume claims for storage
I didn't manage to get the ingress to work properly. Haven't spent too much time debugging the issue.
See review comment regarding nodeSelector, tolerations and affinity

karmenrabar commented 7 months ago

Hello @CarlEkerot, thanks so much for the review! @antejavor is currently on his AL, but he'll get back to you as soon as he's back. I'm glad to hear that it's going successfully for you. Could you tell us what you are working on? :)

CarlEkerot commented 7 months ago

Hello @CarlEkerot, thanks so much for the review! @antejavor is currently on his AL, but he'll get back to you as soon as he's back. I'm glad to hear that it's going successfully for you. Could you tell us what you are working on? :)

Mostly poking around with memgraph and a few other graph DBs :) Looking forward to using this chart once it's in a stable state :+1:

karmenrabar commented 7 months ago

Nice to hear that you're exploring Memgraph, @CarlEkerot :) Feel free to ask if you have more questions, and don't hesitate to reach out on our discord or book an office hours call !

tewnut commented 6 months ago

Been using this somewhat successfully the last week or so. I am not knowledgeable enough in Helm charts to give a proper review, but here are some pointers as a user:

Deploying this from IaC, it would be nice to (optionally) provide existing volume claims for storage

I didn't manage to get the ingress to work properly. Haven't spent too much time debugging the issue.

See review comment regarding nodeSelector, tolerations and affinity

1. Existing chart included PVC. Do you mean we should be able to specify the existing volume, instead of naming the volume in this format `{{ include "memgraph-platform.fullname" . }}-lib-storage`? I have used this intentionally to be consistent with the memgraph chart in this same repo.

2. Can you share the ingress section of your values.yaml file?

katarinasupe commented 6 months ago

Hi @tewnut, thank you so much for providing the chart for the Memgraph Platform. With the Memgraph Lab image being available on the Docker hub now, we have been working on a new way of running the Memgraph Platform that should ease the deployment process, and that's why we still need to review this. With Memgraph 2.15, we will make these changes public, and then we'll see what to do with Helm Charts (how to approach the Memgraph Platform deployment properly).

@CarlEkerot thank you for the review as well! 👏 Stay tuned for the updates 😄

tewnut commented 6 months ago

Hi @tewnut, thank you so much for providing the chart for the Memgraph Platform. With the Memgraph Lab image being available on the Docker hub now, we have been working on a new way of running the Memgraph Platform that should ease the deployment process, and that's why we still need to review this. With Memgraph 2.15, we will make these changes public, and then we'll see what to do with Helm Charts (how to approach the Memgraph Platform deployment properly).

@CarlEkerot thank you for the review as well! 👏 Stay tuned for the updates 😄

Thanks, looking forward to the new release...

tewnut commented 4 months ago

Yeah, I think this is altogether a better approach. Thanks for the update.

Let me try creating the charts for my k8s cluster. When things are in good shape, I will create a PR in this repo, should be a couple of days...

antejavor commented 4 months ago

Yeah, I think this is a better approach altogether. Thanks for the update.

Let me try creating the charts for my k8s cluster. When things are in good shape, I will create a PR in this repo, should be a couple of days...

Keep in mind we updated the contribution guide a bit: https://github.com/memgraph/helm-charts/commit/c1cc60603a8ea2f3572e5f5685190b65b60b7c7b

If you are going to create a new PR, please use the latest release branch and create a PR on a specific release branch.

If you are going to use this PR it is also fine.

antejavor commented 4 months ago

Hi @tewnut can we close this PR now? Since you have open another for Memgraph Lab.

memgraph / helm-charts

Memgraph platform #13

1. Existing chart included PVC. Do you mean we should be able to specify the existing volume, instead of naming the volume in this format {{ include "memgraph-platform.fullname" . }}-lib-storage? I have used this intentionally to be consistent with the memgraph chart in this same repo.

2. Can you share the ingress section of your values.yaml file?

1. Existing chart included PVC. Do you mean we should be able to specify the existing volume, instead of naming the volume in this format `{{ include "memgraph-platform.fullname" . }}-lib-storage`? I have used this intentionally to be consistent with the memgraph chart in this same repo.