search

memgraph / helm-charts

Helm charts for deploying Memgraph, an open-source in-memory graph database.
https://memgraph.github.io/helm-charts/
Apache License 2.0
14 stars 11 forks source link

[Bug]: Service Account #4

Closed jseiser closed 1 year ago

jseiser commented 1 year ago

Contact Details

justinseiser@gmail.com

What happened?

Should be able to define and configure a custom ServiceAccount.

Templating exists: https://github.com/memgraph/helm-charts/blob/main/charts/memgraph/templates/_helpers.tpl#L53

Just need to add the serviceAccount, and then add it to the statefulset

Chart type

Standalone

Chart version

0.1.0

Environment

Local Machine

Relevant log output

No response

matkob commented 4 weeks ago

Hi, though I see some work has been merged, I noticed it didn't introduce the code that was missing in the statefulset template. It's still the case that users can't use their own service account, nor they can use the one created by the memgraph templates. This is due to the fact, there's serviceAccount: {{ .Values.serviceAccount.name | quote }} line missing.

I'm going to submit a PR soon and hope it'll be reviewed even thuough this issue has been closed :)

katarinasupe commented 4 weeks ago

Hi @matkob, thank you for reporting this and please do submit the PR. We can merge it and release it with the next Memgraph release (Nov 6th).

Btw. what are you working on with Memgraph?

matkob commented 4 weeks ago

Hi, I've just submitted the PR. Together with my friends in DSV I'm building a metadata store service based on memgraph 🚀