memgraph / helm-charts

Helm charts for deploying Memgraph, an open-source in-memory graph database.
https://memgraph.github.io/helm-charts/
Apache License 2.0
13 stars 9 forks source link

[Bug]: Allow setting username and password via kubernetes secrets #5

Closed alex-linx closed 1 month ago

alex-linx commented 1 year ago

Contact Details

No response

What happened?

It's not really bug, but a suggestion for the chart. When the chart is installed for the first time it has no username and password so you can just log in. It would be nice to have an optional values setting for setting the username and password.

Ideally it would be possible to set them using both env vars and MEMGRAPH_PASSFILE (which I think is a bit more secure).

Maybe something like this (in values.yaml)

secret:
    secretName: memgraph-secret
    usernKey: MEMGRAPH_USER
    passwordKey: MEMGRAPH_PASSWORD
    passfileKey: MEMGRAPH_PASSKEY

If secretName is defined then:

Chart type

Standalone

Chart version

0.1.0

Environment

Amazon Web Services

Relevant log output

No response

antejavor commented 1 year ago

Hi @alex-linx, thanks for providing this feedback 🙌, we will probably add this in following weeks.

aqeelat commented 2 months ago

Hi @antejavor, any updates?

aqeelat commented 2 months ago

I can open a PR for the change (excluding passfileKey)

antejavor commented 1 month ago

Hi @aqeelat, thanks for reaching out 🚀 , I will fix it in the upcoming release. If you have a template ready feel free to open a PR so we will include it.