memgraph / mage

MAGE - Memgraph Advanced Graph Extensions :crystal_ball:
Apache License 2.0
247 stars 24 forks source link

Fix “Failed to remove the module $MODULE” warnings #213

Closed antepusic closed 2 months ago

antepusic commented 1 year ago

Description

Upon the removal of query modules (e.g. when shutting down Memgraph), warnings such as these are consistently logged:

[2023-04-05 16:35:36.374] [Warning] Failed to remove the module mgp_networkx from sys.modules
[2023-04-05 16:35:36.378] [Warning] Failed to remove the module mgp_igraph from sys.modules
[2023-04-05 16:35:36.428] [Warning] Failed to remove the module igraphalg from sys.modules

This PR fixes the issue by relocating two helper modules (mgp_networkx and mgp_igraph) from /python to /python/mage.

Pull request type

Related issues

212

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

antoniofilipovic commented 6 months ago

@antepusic can we close this?

antepusic commented 6 months ago

@antoniofilipovic I think we’re fine closing this – it was a harmless issue even when the PR was opened

antepusic commented 2 months ago

Closing stale PR per my above message