memgraph / mage

MAGE - Memgraph Advanced Graph Extensions :crystal_ball:
Apache License 2.0
244 stars 24 forks source link

[E-refactor < T374] Add refactor.normalize_as_boolean #367

Closed imilinovic closed 10 months ago

imilinovic commented 11 months ago

Description

Add refactor.normalize_as_boolean

Pull request type

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

imilinovic commented 11 months ago

@antepusic Wanted to discuss how to handle the overlap on the daily tomorrow and potentionally adding List as a valid input parameter so I left the PR in draft. Sorry, should've tagged after converting to real PR.

imilinovic commented 11 months ago

It was decided to extend the procedure to lists as well as it should be a bit better complexity wise (vs calling it for each list element separately due to less copies). Also if a property is contained in both true_values and false_values an exception will be thrown.