memgraph / mage

MAGE - Memgraph Advanced Graph Extensions :crystal_ball:
Apache License 2.0
251 stars 25 forks source link

Add periodic iterate fix on authentication #407

Closed Josipmrden closed 5 months ago

Josipmrden commented 11 months ago

Description

Periodic iterate has not been able to execute queries in an authenticated environment because on one of the paths the client has been connecting to Memgraph without username and password provided. That path has now been covered to provide credentials based on environment variables.

Pull request type

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

Josipmrden commented 11 months ago

@antejavor please create a community issue for this so engineering team can take this over

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

antejavor commented 10 months ago

@Josipmrden I have added the initial issue to the community projects.

vpavicic commented 10 months ago

RN: Periodic iterate is now executed in an authenticated environment as expected.

katarinasupe commented 8 months ago

@Josipmrden is this PR fixing the issue + if it is, does it fix other similar issues too? https://github.com/memgraph/mage/issues/424

vpavicic commented 8 months ago

@Josipmrden is this a part of the 2.14 release or should I just remove the milestone? :D

antoniofilipovic commented 6 months ago

@Josipmrden what is status with this PR?

Josipmrden commented 5 months ago

With v2.16, this is now fixed by another PR