memgraph / mage

MAGE - Memgraph Advanced Graph Extensions :crystal_ball:
Apache License 2.0
251 stars 25 forks source link

Add dockerfile, requirements and test for no ML build #414

Closed antoniofilipovic closed 9 months ago

antoniofilipovic commented 10 months ago

Description

The idea of this PR is to add a Dockerfile for build of MAGE without ML, which is often used when shipping customer images

Pull request type

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

MarkoBarisic commented 10 months ago

Do you think tests for no-ML build should be added to ./github/workflows/test.yml or the tests aren't needed because it can be implied from regular tests?

antoniofilipovic commented 10 months ago

Do you think tests for no-ML build should be added to ./github/workflows/test.yml or the tests aren't needed because it can be implied from regular tests?

Oh, nice idea. I think we should add tests most likely because that way we are sure no-ML image also works. Good catch

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot C 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint