Bugfix: Inverting bool value in rust - Githubissues

memgraph / mage

MAGE - Memgraph Advanced Graph Extensions :crystal_ball:

Apache License 2.0

238 stars 23 forks source link

Bugfix: Inverting bool value in rust #447

Open andrejtonev opened 4 months ago

andrejtonev commented 4 months ago

Description

When executing rust procedures, any boolean arguments get negated.

Pull request type

[x] Bugfix

Related issues

https://github.com/memgraph/mage/issues/426

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

[ ] Core algorithm/module implementation
[ ] Query module implementation
[x] Unit tests
[ ] End-to-end tests
[ ] Code documentation
[ ] README short description
[ ] Documentation on memgraph/docs
[ ] Update GQLALchemy signatures in query builder using query module signature generator

######################################

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

andrejtonev commented 4 months ago

@kgolubic Changelog: Rust bool value conversion fixed.

Ignition commented 4 months ago

Maybe add a test to rust/rsmgp-sys/src/value/tests.rs

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

kgolubic commented 3 months ago

@andrejtonev the milestone is missing. Can you please set it?

andrejtonev commented 3 months ago

@kgolubic mage does not follow the same workflow as memgraph. No milestone is defined.