Open dintorf opened 1 month ago
Hi @dintorf! Thank you so much for detecting this issue and fixing it. As a thank you, I'll reach out to you via email to ask for delivery info so I can send you Memgraph swag 🚀
Awesome! Looking forward to it :)
Hi @dintorf, did you receive my email?
Hi @katarinasupe, I did! I sent a reply. Let me know if you didn’t get it and I’ll send it from a different email address.
Not sure why, but I didn't get the reply. @dintorf please send it for a different email address 🙏
Hi @katarinasupe, I sent you another email last week. Did you happen to receive that one?
Hi @dintorf, I received it! I will respond asap, it's been a busy week 😄
Describe the bug The
build_and_copy_rust_modules
function in thesetup
script does not properly loop through the module directory. Thefilter
function is a generator and is executed on the fly, so since directory changes occur inside the loop theos.path.isdir(f)
part of the loop breaks.To Reproduce Steps to reproduce the behavior:
rust
directory that falls after therust_example
module alphabeticallypython3 setup build --lang rust -p /usr/lib/memgraph/query_modules
query_modules
Expected behavior It's expected that all rust modules in the directory are built and copied to the output path except for
rsmgp-sys
.Screenshots If applicable, add screenshots to help explain your problem.
Additional context This can be fixed by changing the for loop in the
build_and_copy_rust_modules
function to the following: