Fix the missing logic in the new simulator fixes

memgraph / orb

Graph visualization library

Apache License 2.0

363 stars 17 forks source link

Fix the missing logic in the new simulator fixes #87

Closed tonilastre closed 7 months ago

tonilastre commented 8 months ago

Complete and fix the simulator (branch fix/new-simulator):

Remove useless flag isRenderCalledByUser. Check if the flag isSimulationAnimated is used at all and remove it if needed.
Fix and remove TODOs in graph model, simulator engine, and views (which connects model and simulator)

AlexIchenskiy commented 8 months ago

The isSimulationAnimated flag is used to enable or disable the simulation animation. It is enabled by default, and by disabling it, the graph will appear in its final position without moving nodes by the physics engine. However, it does not work in the current version. It can be easily fixed by preventing the simulation from rendering while in progress, but the animation will still be present while dragging nodes or zooming. Is it better to completely remove it or to maintain this fix?

tonilastre commented 8 months ago

I would say that let's remove it, we can always add it later on.