There is some difference in the behavior at this point, that's for the discussion as well.
Connection::pull_all is a private method used in one place, it could be inlined, but that's more-less equivalent.
In the Python case, the cursor is there because of https://www.python.org/dev/peps/pep-0249/. In the Rust case, that clearly defined API doesn't exist. I would keep that simple for now.
Closes #28
InTransaction
status.match
+Result
seems quite good to me because it's contained in one block. There is a difference between https://github.com/memgraph/pymgclient/blob/master/src/connection-int.c#L77 ("internal" error handling) and https://github.com/memgraph/pymgclient/blob/master/src/cursor.c#L156 ("public" error handling). It seems to me that Rust's pattern matching +Result
combines everything in one place. Long story short, I would leave that as is (the Rust structure), but we should discuss :smile: to make lasting changes.Connection::pull_all
is a private method used in one place, it could be inlined, but that's more-less equivalent.