memiiso / debezium-server-iceberg

Replicates any database (CDC events) to Apache Iceberg (To Cloud Storage)
Apache License 2.0
174 stars 35 forks source link

[Improvement] Use Append Iceberg Commit for Append Mode #187

Closed wobu closed 1 year ago

wobu commented 1 year ago

When using the append mode in the debezium server iceberg project still Overwrite Commits are produced in the Iceberg table even if Append Commits would also technical work.

Append Commits / Snapshots in the Iceberg Table are have some benefits:

This should be easy fixable:

Enhance the code at https://github.com/memiiso/debezium-server-iceberg/blob/master/debezium-server-iceberg-sink/src/main/java/io/debezium/server/iceberg/tableoperator/IcebergTableOperator.java#L182 with this check https://github.com/apache/iceberg/blob/master/flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java#L349

ismailsimsek commented 1 year ago

@wobu good point. adding if else with files.deleteFiles().length > 0 should be enough right?

do you want to contribute it?

wobu commented 1 year ago

@ismailsimsek shoud be sufficient with my understanding

we will contribute, if we decide to focus on using this project. Currently the decision hasn't been made. Until then anyone is allowed to contribute :)