search

memo / ofxMSAOpenCL

C++ openFrameworks addon for very simple to use wrapper for OpenCL. All underlying openCL objects are accessible to allow advanced features too if need be
http://www.memo.tv/ofxmsaopencl/
Other
88 stars 35 forks source link

Added offset to method run #18

Closed mmestucci closed 7 years ago

mmestucci commented 8 years ago

Added offset to method run

memo commented 7 years ago

Thanks for this patch. I can see why this is a useful thing to have, and I wish I'd included it from the beginning, but adding this parameter now as the 3rd argument will break all backwards compatibility, because for any applications which are currently using this addon, people will have called the run method passing in localsize as 3rd agument. But with this patch the 3rd argument will be interpreted as localsize etc. So even though it's not an elegant solution, the safe solution would be to add the offset to the end of the parameters, and give it a default value of 0. I'll think about an alternative approach that would be safe and elegant.