search

memo33 / sc4pac

Metadata channel of package manager Sc4pac
https://memo33.github.io/sc4pac/
GNU General Public License v3.0
6 stars 7 forks source link

add andisart sunken lots #23

Closed noah-severyn closed 6 months ago

noah-severyn commented 6 months ago

Add andisart sunken lots and my remake of them. I'm picking up on more of the syntax; feel free to correct anything still wrong. :)

noah-severyn commented 6 months ago

Fixed some errors. Not sure what the remaining ones are.

memo33 commented 6 months ago

Thanks. I've fixed the lint error. The include properties are defined for each individual asset in the list of assets, so they need to be indented.

A few thoughts:

The nos17:sunken-lots seems to use the wrong asset.

I'm not sure splitting the lots into eyecandy/functional is really needed. If someone decides to install them, I think it would be fine to have all 5 lots, so I'd prefer to merge the two packages into one to reduce complexity.

The summaries could include a bit more information that distinguishes the packages (as long as the summaries are reasonably short), as only the summary is shown on the main channel page.

Also, you can refer to additional optional packages in the description to point out that they exist and can be installed as well. Using the syntax `pkg=andisart:sunken-lots-eyecandy` creates a hyperlink.

Also consider releasing your stuff on the STEX for discoverability. This would also help with maintainability of the metadata, as it's more likely that checking version numbers and last-modified timestamps for updates will be automated for STEX files than for forum attachments (currently this is only implemented for SC4E, not ST yet).

memo33 commented 6 months ago

What happened?

noah-severyn commented 6 months ago

I must have messed something up and closed by accident. I agree with you on the changes and I'll reopen once I make them.