search

memo33 / sc4pac

Metadata channel of package manager Sc4pac
https://memo33.github.io/sc4pac/
GNU General Public License v3.0
6 stars 7 forks source link

B62 remastered content #27

Closed noah-severyn closed 1 month ago

memo33 commented 3 months ago

Please make sure to test the installation of the packages, especially ensuring that all the desired files get extracted and installed. You know best whether the installed files are complete. This cannot be automated, so needs to be tested manually. You can build the channel locally using sc4pac channel build --output my-local-channel src/yaml and then add it for testing sc4pac channel add "file:///C:/absolute/path/to/my-local-channel".

One more thing I noticed: In YAML, the > character indicates that text is wrapped, so to add a linebreak one needs to separate paragraphs by an empty line (i.e. 2 linebreaks). Use | if you want to preserve all linebreaks.

noah-severyn commented 2 months ago

I did forget we could test. I'll let you know again here when I've been through everything.

noah-severyn commented 1 month ago

@memo33 Everything tested ok. This should be good to close and merge now.

memo33 commented 1 month ago

I'm currently working on some updates for this PR (after just having integrated the STEX API into GH Actions).

The STEX description of the Sears Grand lists "BSC Mega Props - KevDan25 Vol01" as dependency which is missing in your metadata. Intentionally?

memo33 commented 1 month ago

Your scripts seem to garble up text containing double quotes.

Also, for the verizon tower, I'm going to remove the takemethere:mount-royal-transmission-tower dependency. It seems redundant as you already extract the corresponding asset itself.

memo33 commented 1 month ago

The pond variant of b62:sears-grand seems to install lots only. Which files would be correct here?

300-commercial/b62.sears-grand.pond.3.sc4pac/
├── PLOP_16x13_B62-PLOP_SearsGrand_MB v.3.41_166d1f2b.SC4Lot
├── PLOP_19x9_B62-PLOP_SearsGrand_Pond-Parking_a66d2090.SC4Lot
└── PLOP_3x13_B62-PLOP_SearsGrand_Pond_2673947c.SC4Lot

Ok, I've made my changes. Other than the points mentioned above, this is good to go if you are happy with the changes. (The CI is broken currently for reasons unrelated to this PR.)

Among other things, I've removed most of the stats as they are pretty useless, so there's no point of keeping track of them here in this repository.

noah-severyn commented 1 month ago
  1. On the descriptions, it's clear you're favoring shorter ones. I will note this for the future and rewrite the STEX entry descriptions for brevity. Removing the stats is fine.
  2. KevDan25 Vol01 is incorrectly missing - fixed
  3. Transmission tower - noted
  4. b62.sears-grand.pond.3 should also be installing models - fixed.
memo33 commented 1 month ago

On the descriptions, it's clear you're favoring shorter ones. I will note this for the future and rewrite the STEX entry descriptions for brevity. Removing the stats is fine.

I tend to prefer shorter descriptions to make it easier to find the truly relevant infos, so that hopefully users don't skip it. Plugins that are more complex to use can have longer descriptions, of course. On the STEX, the descriptions can stay as is.

KevDan25 Vol01 is incorrectly missing - fixed

I've moved it to the pond variant, as mentioned on the STEX entry. I've also separated the Zaxby's model from its lots so that the model can be used as a stand-alone dependency.

b62.sears-grand.pond.3 should also be installing models - fixed.

There seems to be one more issue with the no-pond variant. The second lot (Parking Lot) does not appear in the menus. I found it in the building plop menu under "B62…", but it cannot be placed regardless.

noah-severyn commented 1 month ago

Alright hopefully that should fix it - updated the STEX entry. Thank you for your patience with this memo.

memo33 commented 1 month ago

Thanks for the fixes. Still something is wrong with the STEX upload, as it contains all the files twice.

B62-SearsGrand
├── B62-SearsGrand
│   ├── b62 pylonsign-searsgrand v.1.1-0x5ad0e817_0x50ec22ad_0x490000.SC4Model
│   ├── b62 pylonsign-searsgrand v.1.1-0x6534284a-0x50ec22ad-0xf16a3219.SC4Desc
│   ├── B62-SearsGrand
│   │   ├── b62 pylonsign-searsgrand v.1.1-0x5ad0e817_0x50ec22ad_0x490000.SC4Model
│   │   ├── b62 pylonsign-searsgrand v.1.1-0x6534284a-0x50ec22ad-0xf16a3219.SC4Desc
│   │   ├── b62_SearsGrand_MB v.3.41-0x5ad0e817_0x50ec22ad_0x470000.SC4Model
│   │   ├── b62_SearsGrand_MB v.3.41-0x6534284a-0x50ec22ad-0xd16a0a76.SC4Desc
│   │   ├── b62 Shell_DrinkCenter v 1.1-0x5ad0e817_0x131ed1ac_0x30000.SC4Model
│   │   ├── b62 Shell_DrinkCenter v 1.1-0x6534284a-0x50ec22ad-0xf3217655.SC4Desc
│   │   ├── b62 Shell_MIGM v 1.2-0x5ad0e817_0xf31d9579_0x30000.SC4Model
│   │   ├── b62 Shell_Pylon_TSign v 2.1-0x5ad0e817_0xf31e7fe0_0x30000.SC4Model
│   │   ├── b62 Shell_Pylon_TSign v 2.1-0x6534284a-0x50ec22ad-0x33212331.SC4Desc
│   │   ├── PROP_b62 Shell_MIGM v 1.2-0x6534284a-0xd1e3b8fd-0x13194fdd.SC4Desc
│   │   └── PROP_Zaxby's-0x6534284a-0xd1e3b8fd-0x131ad2be.SC4Desc
│   ├── b62_SearsGrand_MB v.3.41-0x5ad0e817_0x50ec22ad_0x470000.SC4Model
│   ├── b62_SearsGrand_MB v.3.41-0x6534284a-0x50ec22ad-0xd16a0a76.SC4Desc
│   ├── b62 Shell_DrinkCenter v 1.1-0x5ad0e817_0x131ed1ac_0x30000.SC4Model
│   ├── b62 Shell_DrinkCenter v 1.1-0x6534284a-0x50ec22ad-0xf3217655.SC4Desc
│   ├── b62 Shell_MIGM v 1.2-0x5ad0e817_0xf31d9579_0x30000.SC4Model
│   ├── b62 Shell_Pylon_TSign v 2.1-0x5ad0e817_0xf31e7fe0_0x30000.SC4Model
│   ├── b62 Shell_Pylon_TSign v 2.1-0x6534284a-0x50ec22ad-0x33212331.SC4Desc
│   ├── KEEP ONE ... Diggis Version
│   │   ├── PLOP_16x13_B62-PLOP_SearsGrand_MB v.3.41_166d1f2b.SC4Lot
│   │   ├── PLOP_19x9_B62-PLOP_SearsGrand_Pond-Parking_a66d2090.SC4Lot
│   │   └── PLOP_3x13_B62-PLOP_SearsGrand_Pond_2673947c.SC4Lot
│   ├── KEEP ONE ... Non-Diggis Version
│   │   ├── B62-PLOP_SearsGrand_Parking-0x6534284a-0xd3a3e650-0xb6740c84.SC4Desc
│   │   ├── PLOP_14x13_B62-PLOP_SearsGrand_MB v.3.41_e66b1122.SC4Lot
│   │   └── PLOP_16x9_B62-PLOP_SearsGrand_NoPond-Parking_766b0f9d.SC4Lot
│   ├── PROP_b62 Shell_MIGM v 1.2-0x6534284a-0xd1e3b8fd-0x13194fdd.SC4Desc
│   ├── PROP_Zaxby's-0x6534284a-0xd1e3b8fd-0x131ad2be.SC4Desc
│   └── Read Me - Sears Grand.txt
├── KEEP ONE ... Diggis Version
│   ├── PLOP_16x13_B62-PLOP_SearsGrand_MB v.3.41_166d1f2b.SC4Lot
│   ├── PLOP_19x9_B62-PLOP_SearsGrand_Pond-Parking_a66d2090.SC4Lot
│   └── PLOP_3x13_B62-PLOP_SearsGrand_Pond_2673947c.SC4Lot
├── KEEP ONE ... Non-Diggis Version
│   ├── B62-PLOP_SearsGrand_Parking-0x6534284a-0xd3a3e650-0xb6740c84.SC4Desc
│   ├── PLOP_14x13_B62-PLOP_SearsGrand_NoPond_e66b1122.SC4Lot
│   └── PLOP_16x9_B62-PLOP_SearsGrand_NoPond-Parking_766b0f9d.SC4Lot
└── Read Me - Sears Grand.txt

8 directories, 36 files
noah-severyn commented 1 month ago

Shit. Fixed. Thank you.

memo33 commented 1 month ago

Let's goooo.